EVEREST-1841 MongoDB Major Version Upgrades #1080
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
recharte
force-pushed
the
EVEREST-1841-mongodb-major-upgrades
branch
2 times, most recently
from
15d0cf7 to
7655fe2
Compare
recharte
force-pushed
the
EVEREST-1841-mongodb-major-upgrades
branch
from
b66cf9e to
bfc3a38
Compare
dianabirs
approved these changes
Feb 14, 2025
recharte
force-pushed
the
EVEREST-1841-mongodb-major-upgrades
branch
from
c088568 to
2185272
Compare
fabio-silva
approved these changes
Feb 14, 2025
maxkondr
reviewed
Mar 3, 2025
| newMajorInt, _ := strconv.Atoi(semver.Major(newVersion)[1:]) | ||
| oldMajorInt, _ := strconv.Atoi(semver.Major(oldVersion)[1:]) | ||
| // We will not allow major upgrades if the versions are not sequential. | ||
| if newMajorInt-oldMajorInt > 1 { |
There was a problem hiding this comment.
what if newMajor version < oldMajor version?
There was a problem hiding this comment.
looks like this case is validated earlier in the function, the errDBEngineDowngrade will be returned
oksana-grishchenko
approved these changes
Mar 3, 2025
| newMajorInt, _ := strconv.Atoi(semver.Major(newVersion)[1:]) | ||
| oldMajorInt, _ := strconv.Atoi(semver.Major(oldVersion)[1:]) | ||
| // We will not allow major upgrades if the versions are not sequential. | ||
| if newMajorInt-oldMajorInt > 1 { |
There was a problem hiding this comment.
looks like this case is validated earlier in the function, the errDBEngineDowngrade will be returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlock major version upgrades for MongoDB.
Related pull requests